Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a GEP method to blockext, simply some code #873

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

edg-l
Copy link
Member

@edg-l edg-l commented Oct 21, 2024

Related to #862

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@edg-l edg-l added the review-ready A PR that is ready for review label Oct 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 70.29586% with 251 lines in your changes missing coverage. Please review.

Project coverage is 82.91%. Comparing base (f39cb35) to head (ce9843e).

Files with missing lines Patch % Lines
src/libfuncs/starknet.rs 15.26% 211 Missing ⚠️
src/libfuncs/starknet/secp256.rs 92.64% 40 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #873      +/-   ##
==========================================
+ Coverage   82.82%   82.91%   +0.08%     
==========================================
  Files         120      120              
  Lines       34941    33864    -1077     
==========================================
- Hits        28941    28079     -862     
+ Misses       6000     5785     -215     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 21, 2024

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.055 ± 0.248 10.749 11.600 24.65 ± 0.55
cairo-native (embedded AOT) 3.323 ± 0.061 3.231 3.426 7.41 ± 0.14
cairo-native (embedded JIT using LLVM's ORC Engine) 3.321 ± 0.054 3.267 3.453 7.40 ± 0.12
cairo-native (standalone AOT) 0.676 ± 0.004 0.673 0.685 1.51 ± 0.01
cairo-native (standalone AOT with -march=native) 0.449 ± 0.001 0.448 0.451 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.139 ± 0.337 10.650 11.490 1387.28 ± 43.06
cairo-native (embedded AOT) 2.769 ± 0.014 2.745 2.790 344.81 ± 2.97
cairo-native (embedded JIT using LLVM's ORC Engine) 2.769 ± 0.024 2.738 2.808 344.90 ± 3.81
cairo-native (standalone AOT) 0.008 ± 0.000 0.008 0.010 1.04 ± 0.02
cairo-native (standalone AOT with -march=native) 0.008 ± 0.000 0.008 0.009 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 4.333 ± 0.035 4.275 4.393 61.14 ± 0.52
cairo-native (embedded AOT) 2.895 ± 0.026 2.855 2.932 40.85 ± 0.38
cairo-native (embedded JIT using LLVM's ORC Engine) 3.080 ± 0.027 3.043 3.139 43.46 ± 0.40
cairo-native (standalone AOT) 0.115 ± 0.000 0.114 0.115 1.62 ± 0.00
cairo-native (standalone AOT with -march=native) 0.071 ± 0.000 0.071 0.072 1.00

Copy link

github-actions bot commented Oct 21, 2024

Benchmark results Main vs HEAD.

Command Mean [s] Min [s] Max [s] Relative
head factorial_2M.cairo (JIT) 3.217 ± 0.018 3.195 3.251 1.01 ± 0.01
base factorial_2M.cairo (JIT) 3.233 ± 0.024 3.206 3.271 1.02 ± 0.01
head factorial_2M.cairo (AOT) 3.177 ± 0.021 3.141 3.208 1.00
base factorial_2M.cairo (AOT) 3.211 ± 0.022 3.177 3.246 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
head fib_2M.cairo (JIT) 2.760 ± 0.013 2.731 2.776 1.01 ± 0.01
base fib_2M.cairo (JIT) 2.773 ± 0.017 2.746 2.790 1.01 ± 0.01
head fib_2M.cairo (AOT) 2.735 ± 0.017 2.709 2.763 1.00
base fib_2M.cairo (AOT) 2.750 ± 0.013 2.732 2.769 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
head logistic_map.cairo (JIT) 3.054 ± 0.022 3.010 3.076 1.06 ± 0.01
base logistic_map.cairo (JIT) 3.045 ± 0.016 3.016 3.063 1.05 ± 0.01
head logistic_map.cairo (AOT) 2.892 ± 0.015 2.876 2.917 1.00
base logistic_map.cairo (AOT) 2.898 ± 0.014 2.880 2.926 1.00 ± 0.01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-ready A PR that is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants