Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alloc_mlir_array. #503

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Fix alloc_mlir_array. #503

merged 2 commits into from
Mar 27, 2024

Conversation

azteca1998
Copy link
Collaborator

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@azteca1998 azteca1998 marked this pull request as ready for review March 27, 2024 14:18
@azteca1998 azteca1998 linked an issue Mar 27, 2024 that may be closed by this pull request
juanbono
juanbono previously approved these changes Mar 27, 2024
Copy link

github-actions bot commented Mar 27, 2024

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 13.553 ± 0.033 13.502 13.603 31.04 ± 0.31
cairo-native (embedded AOT) 1.581 ± 0.026 1.539 1.627 3.62 ± 0.07
cairo-native (embedded JIT using LLVM's ORC Engine) 1.557 ± 0.024 1.521 1.593 3.57 ± 0.06
cairo-native (standalone AOT) 0.636 ± 0.001 0.634 0.638 1.46 ± 0.01
cairo-native (standalone AOT with -march=native) 0.437 ± 0.004 0.434 0.448 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 13.119 ± 0.067 13.035 13.229 1617.84 ± 19.51
cairo-native (embedded AOT) 1.080 ± 0.016 1.063 1.114 133.16 ± 2.50
cairo-native (embedded JIT using LLVM's ORC Engine) 1.112 ± 0.023 1.092 1.161 137.11 ± 3.19
cairo-native (standalone AOT) 0.008 ± 0.000 0.008 0.008 1.01 ± 0.02
cairo-native (standalone AOT with -march=native) 0.008 ± 0.000 0.008 0.008 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 1.898 ± 0.013 1.881 1.926 27.91 ± 0.26
cairo-native (embedded AOT) 1.210 ± 0.013 1.190 1.227 17.79 ± 0.22
cairo-native (embedded JIT using LLVM's ORC Engine) 1.447 ± 0.017 1.429 1.474 21.29 ± 0.28
cairo-native (standalone AOT) 0.112 ± 0.001 0.112 0.114 1.65 ± 0.01
cairo-native (standalone AOT with -march=native) 0.068 ± 0.000 0.068 0.070 1.00

Copy link
Member

@juanbono juanbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@juanbono juanbono added this pull request to the merge queue Mar 27, 2024
Merged via the queue into main with commit 4cd14b1 Mar 27, 2024
9 checks passed
@juanbono juanbono deleted the small-array-glue-code-fix branch March 27, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: incorrect nonce value
3 participants