This repository has been archived by the owner on Sep 22, 2024. It is now read-only.
Atom generator #20
Open
Atom generator #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that it is better but maybe we can leave Orangeade.Generator.ASCIIAtom without changes and create another module which generates atoms which consist only of alphabet characters? Then we would have one module for generating ascii atoms and another for generating alphabet character atoms. The name for the atom generator can be misleading now. Or maybe it will be enough to change name from |
|
Yeah, I also thought of changing the module name (so that we have |
added 2 commits
May 2, 2018 18:17
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not related to recent issues, but I thought a bit of atom generator. I changed the implementation we had, so that the atoms are sometimes meaningful. I added a module with alphabet character generator and use that. Anyone thinks it's better/worse?