-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement notifications HUD #488
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall pretty good, however I think there needs to be more configuration options, even an option to return back to just sending notifications in chat as some people would prefer that.
src/main/kotlin/com/lambda/client/gui/hudgui/elements/client/Notifications.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/lambda/client/manager/managers/NotificationManager.kt
Outdated
Show resolved
Hide resolved
I think a more opinionated set of rendering options works best for notifications, rather than letting users drag this around to random locations I've also added a few configuration options to the rendering, updated the rendering to handle different scales, and removed most hardcoded numbers. This lets us handle different window sizes better while still allowing some configuration by users within boundaries.
I like the idea! I've made some changes on my branch if you'd like to merge that into yours. Things I've changed:
|
Merged it with a bit of changes. Now I can continue work with animations. |
Fade effects demo 2023-02-12.16-43-49.mp4 |
I've made animation on my brach! cuted_notification.mov |
Good work comrade! Merged it 👍 |
Fix y moving animation here |
Describe the pull
Implement nice looking notifications HUD. At the current state, nothing more than just draft to demonstrate what im wanna do and collect suggestions and improvements from community.
Describe how this pull is helpful
This element will help to focus the player's attention on important events in the game. For example, the use of the totem of immortality by the opponent or other important things. In the current implementation, sending chat notifications is very easy not to notice them with a huge flow of messages. It also adds more usefulness, beauty and convenience to our client.
Additional context
Notifications demo in current state.
2023-02-05.23-02-37.mp4