Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StashLogger: Add logToFile option #469

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Baitinq
Copy link
Contributor

@Baitinq Baitinq commented Jan 19, 2023

This patch adds the logToFile option in the StashLogger module. This option, which is enabled by default, appends all the newfound stashes to a JSON file ($lambda_folder/stash_logger.json).

This is useful for when you are afk stash hunting and you would like to keep a log of all the found stashes :)

@Avanatiker
Copy link
Member

Cool idea, should be saved in a folder named "stash-logger" and have separate files for very server using the brand. Otherwise it would combine indistinguishable the location from different servers.

This patch adds the logToFile option in the StashLogger module. This
option, which is enabled by default, appends all the newfound stashes to
a JSON file ($lambda_folder/stash-logger/servername.json).

This is useful for when you are afk stash hunting and you would like to
keep a log of all the found stashes :)
@Baitinq
Copy link
Contributor Author

Baitinq commented Feb 2, 2023

@Avanatiker should be done :)

@P529
Copy link
Contributor

P529 commented May 2, 2023

After finding the first stash it doesnt log any other stashes.

Ive set up a small test on a local server, 2 locations with 5+ shulkers each, the first one will get found everytime but the second one doesnt get logged as a stash.

Also, once the first json was created the stash logger didnt seem to create any new json files.

Getting "FileAlreadyExistsException".

Also, I'd suggest adding a new default folder to the FolderUtils for the stash logger if you want this to be a mainline feature. Maybe someone else can chime in if there is something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants