LAM-1169 feat: cache configs to disk #1190
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siiky
force-pushed
the
feat/lam-1169/cache-configs-to-disk
branch
6 times, most recently
from
b60ac56
to
fa6c436
Compare
siiky
force-pushed
the
feat/lam-1169/cache-configs-to-disk
branch
from
75104d2
to
54ce796
Compare
siiky
changed the title
siiky
force-pushed
the
feat/lam-1169/cache-configs-to-disk
branch
from
79eb3ac
to
bce5003
Compare
RafaelTaranto
requested changes
Oct 14, 2024
RafaelTaranto
requested changes
Oct 14, 2024
There was a problem hiding this comment.
Another more general thing. This would benefit from having a separate folder under lib, either /db, /settings, /config or something in this vein. We can then have a pretty closed module.
Would be good to add testing for this as well, you can use vitest, maybe will have to search on how to use vitest without vite.
siiky
force-pushed
the
feat/lam-1169/cache-configs-to-disk
branch
8 times, most recently
from
1497f45
to
309bf26
Compare
siiky
force-pushed
the
feat/lam-1169/cache-configs-to-disk
branch
4 times, most recently
from
07edf78
to
987eb15
Compare
siiky
force-pushed
the
feat/lam-1169/cache-configs-to-disk
branch
4 times, most recently
from
32650cc
to
6bcdd55
Compare
siiky
force-pushed
the
feat/lam-1169/cache-configs-to-disk
branch
from
6bcdd55
to
e4ce4c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.