lint error, and disclaimer for hashbrown

lalitb · Mar 1, 2024 · d8c56da · d8c56da
1 parent 44efee7
commit d8c56da
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 9 deletions.
diff --git a/opentelemetry-sdk/Cargo.toml b/opentelemetry-sdk/Cargo.toml
@@ -56,6 +56,7 @@ testing = ["opentelemetry/testing", "trace", "metrics", "logs", "rt-async-std",
 rt-tokio = ["tokio", "tokio-stream"]
 rt-tokio-current-thread = ["tokio", "tokio-stream"]
 rt-async-std = ["async-std"]
+# Enable use_hashbrown for critical performance when measurement attributes are secure and not prone to external manipulation.
 use_hashbrown = ["hashbrown", "ahash"]
 
 [[bench]]

diff --git a/opentelemetry-sdk/src/metrics/internal/sum.rs b/opentelemetry-sdk/src/metrics/internal/sum.rs
@@ -219,9 +219,10 @@ impl<T: Number<T>> Sum<T> {
                     }
                 }
                 Err(e) => {
-                    global::handle_error(MetricsError::Other(
-                        format!("Failed to acquire lock on bucket due to: {:?}", e).into(),
-                    ));
+                    global::handle_error(MetricsError::Other(format!(
+                        "Failed to acquire lock on bucket due to: {:?}",
+                        e
+                    )));
                 }
             }
         }
@@ -410,9 +411,10 @@ impl<T: Number<T>> PrecomputedSum<T> {
                 }
                 Err(e) => {
                     // Log or handle the lock acquisition error if necessary
-                    global::handle_error(MetricsError::Other(
-                        format!("Failed to acquire lock on bucket due to: {:?}", e).into(),
-                    ));
+                    global::handle_error(MetricsError::Other(format!(
+                        "Failed to acquire lock on bucket due to: {:?}",
+                        e
+                    )));
                     // Continue to the next bucket if the lock cannot be acquired
                     continue;
                 }
@@ -488,9 +490,10 @@ impl<T: Number<T>> PrecomputedSum<T> {
                 Ok(bucket) => bucket,
                 Err(e) => {
                     // Log the error or handle it as needed.
-                    global::handle_error(MetricsError::Other(
-                        format!("Failed to acquire lock on bucket due to: {:?}", e).into(),
-                    ));
+                    global::handle_error(MetricsError::Other(format!(
+                        "Failed to acquire lock on bucket due to: {:?}",
+                        e
+                    )));
                     continue; // Skip to the next bucket if the lock cannot be acquired.
                 }
             };