-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for local_settings.py settings override file #190
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comments.
for own reference,
background on what the local_settings.py
file is and why one would use it: netbox-community/netbox#16127
…efaults, needs testing
I've committed changes but still need to test them. |
Just for future reference
We have a couple other role variables that only get used if they're defined, but just left commented out in the documentation and defaults file, so I applied that pattern here. |
I just noticed: congrats on being the 100th PR on this project! |
This PR configures local_settings.py.
This is required for the deployment of the branch plugin as this file must exist before the migrations are run if the plugin is enabled. You can't otherwise use this role if you want the branch plugin.
{{ playbook_dir }}/files/netbox/local_settings.py
, files/netbox as local_settings.py is a generic name that could be used by other plays or roles.