Skip to content

Commit

Permalink
fix(rcontrib): Fixed a options bug relating to on_setattr mehod
Browse files Browse the repository at this point in the history
I removed the call to on_setattr from the super class (rtrace) as most of the options being invoked and checked there are not relevant to rcontrib or rfluxmtx.
  • Loading branch information
built-test authored and built-tools committed Jan 12, 2022
1 parent 858df58 commit 30feb33
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions honeybee_radiance_command/options/rcontrib.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,11 @@ def _on_setattr(self):
instance in rtrace option collection -ti and -te are exclusive. You can include a
check to ensure this is always correct.
"""
RtraceOptions._on_setattr(self)
# -r and -fo cannot both be True.
if not hasattr(self, 'r'):
return # this happens on init
# -i and -I cannot both be True.
assert not (self.i == True and self.I == True), \
'You can either set -i or -I to True not both.'
if self.r.is_set and self.fo.is_set:
raise exceptions.ExclusiveOptionsError(self.command, 'r', 'fo')
if self.m.is_set and self.M.is_set:
Expand Down

0 comments on commit 30feb33

Please sign in to comment.