Skip to content

Commit

Permalink
fix(util): Broaden check to catch all cases on Mac
Browse files Browse the repository at this point in the history
  • Loading branch information
chriswmackey authored and Chris Mackey committed Jun 6, 2022
1 parent 4e1dc21 commit 11f7797
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
2 changes: 1 addition & 1 deletion honeybee_radiance_command/_command_util.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def run_command(input_command, env=None, cwd=None, mute=True):
# this is an edge case that is happening for certain commands on Mac when
# the command is executed from inside IronPython 2.7
# see: https://discourse.ladybug.tools/t/hdr-adjust-false-color-not-working-on-mac/16941/3
if 'Cannot redirect stderr to stdout yet' in str(e):
if platform.system() == 'Darwin':
process = subprocess.Popen(
command, stdin=subprocess.PIPE, stdout=subprocess.PIPE,
stderr=subprocess.PIPE, shell=True, env=g_env
Expand Down
7 changes: 2 additions & 5 deletions honeybee_radiance_command/options/falsecolor.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
BoolOption,
NumericOption,
StringOption,
StringOptionJoined,
IntegerOption,
FileOption
)
Expand Down Expand Up @@ -58,7 +57,7 @@ def __init__(self):
self._g = StringOption("g", "Green channel mapping (expression of 'v')")
self._b = StringOption("b", "Blue channel mapping (expression of 'v')")
self._on_setattr_check = True

def _on_setattr(self):
"""This method executes after setting each new attribute.
Expand Down Expand Up @@ -97,7 +96,6 @@ def s(self):
@s.setter
def s(self, value):
self._s.value = value


@property
def m(self):
Expand Down Expand Up @@ -198,7 +196,6 @@ def lw(self):
def lw(self, value):
self._lw.value = value


@property
def lh(self):
"""Legend height in pixels - default: 200
Expand Down Expand Up @@ -248,7 +245,7 @@ def g(self):
@g.setter
def g(self, value):
self._g.value = value

@property
def b(self):
"""Blue channel mapping as an expression of 'v'
Expand Down

0 comments on commit 11f7797

Please sign in to comment.