This repository has been archived by the owner on May 24, 2020. It is now read-only.
change hypercube systemd service type to get it in active state at start #71
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi !
I was doing some experiments with the
hypercube.sh
script and I noticed its systemd service never goes in active state. The reason is : because the service unit is of the oneshot type, the state isactivating (start)
during the execution (once it has successfully ran, it directly goes toinactive (dead)
).But I can not find a reason for this. No service needs to wait for it to finish its execution before being started (like the
hypercube.sh
depends onfirstrun.service
andsecondrun.service
) since it does the cube's setup until the end. Plus, since it provides a web server (SimpleHTTPServer
), I think thehypercube.sh
script isn't just a regular one-task shell script.Thus, I think the type
simple
(as set in this PR) would be more convenient for this service.I tested this change by reinstalling from scratch my lime2.