fix(BA-515): Let the vfolder REST API accept vfolder UUIDs as intended #3451
+226
−267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: octodog <[email protected]>
github-actions
bot
added
area:docs
Co-authored-by: octodog <[email protected]>
Co-authored-by: octodog <[email protected]>
Co-authored-by: octodog <[email protected]>
Co-authored-by: octodog <[email protected]>
…nstead of directly reading request.match_info
Co-authored-by: octodog <[email protected]>
Co-authored-by: octodog <[email protected]>
3 tasks
fregataa
reviewed
Jan 15, 2025
Comment on lines
+297
to
+307
| folder_name_or_id: str | uuid.UUID | ||
| piece = request.match_info["name"] | ||
| try: | ||
| folder_name_or_id = uuid.UUID(piece) | ||
| except ValueError: | ||
| folder_name_or_id = piece | ||
| return await handler( | ||
| request, await resolve_vfolder_rows(request, perm, folder_name), *args, **kwargs | ||
| request, | ||
| await resolve_vfolder_rows(request, perm, folder_name_or_id), | ||
| *args, | ||
| **kwargs, |
There was a problem hiding this comment.
How about parsing folder id value to UUID in resolve_vfolder_rows() rather than in with_vfolder_rows_resolved()?
There are some handler functions that call resolve_vfolder_rows()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3450 (BA-515)
Checklist: (if applicable)
📚 Documentation preview 📚: https://sorna--3451.org.readthedocs.build/en/3451/
📚 Documentation preview 📚: https://sorna-ko--3451.org.readthedocs.build/ko/3451/