fix(BA-461): Filter vfolder deletion info by vfolder status #3446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
comp:manager
github-actions
bot
added
area:docs
Co-authored-by: octodog <[email protected]>
Co-authored-by: octodog <[email protected]>
fregataa
added
action:on hold
Comment on lines
-806
to
-810
| async with engine.begin_session() as db_conn: | ||
| result = await db_conn.execute(query) | ||
| target_vfs = result.fetchall() | ||
| delete_query = sa.delete(vfolders).where(vfolders.c.group == group_id) | ||
| result = await db_conn.execute(delete_query) |
There was a problem hiding this comment.
Can I know the existing code history?
| vfolder_permissions.delete().where(vfolder_permissions.c.user == user_uuid), | ||
| ) | ||
| result = await conn.execute( | ||
| sa.select([vfolders.c.id, vfolders.c.host, vfolders.c.quota_scope_id]) |
There was a problem hiding this comment.
Can the existing condition be removed?
lablup-octodog
added a commit
that referenced
this pull request
Jan 17, 2025
Co-authored-by: octodog <[email protected]> Backported-from: main (24.12) Backported-to: 24.09 Backport-of: 3446
lablup-octodog
added a commit
that referenced
this pull request
Jan 17, 2025
Co-authored-by: octodog <[email protected]> Backported-from: main (24.12) Backported-to: 24.03 Backport-of: 3446
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BA-461
resolves #3394
Filter vfolders by status before calling initiate_vfolder_deletion(), rather than checking the status within the function. This approach ensures consistent vfolder status throughout the transaction.
Checklist: (if applicable)
📚 Documentation preview 📚: https://sorna--3446.org.readthedocs.build/en/3446/
📚 Documentation preview 📚: https://sorna-ko--3446.org.readthedocs.build/ko/3446/