Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(BA-454): Directly retrieve VFolder by folder ID in purge API #3388

Merged
merged 6 commits into from
Jan 11, 2025
Merged

fix(BA-454): Directly retrieve VFolder by folder ID in purge API #3388

merged 6 commits into from
Jan 11, 2025

Conversation

fregataa
Copy link
Member

@fregataa fregataa commented Jan 7, 2025 •
edited
Loading

resolves #3383

Implemented as approach 1 - avoid calling query_accessible_vfolders() in purge API

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • API server-client counterparts (e.g., manager API -> client SDK)

📚 Documentation preview 📚: https://sorna--3388.org.readthedocs.build/en/3388/

📚 Documentation preview 📚: https://sorna-ko--3388.org.readthedocs.build/ko/3388/

@fregataa fregataa added this to the 24.03 milestone Jan 7, 2025
@fregataa fregataa self-assigned this Jan 7, 2025
@github-actions github-actions bot added area:docs Documentations comp:manager Related to Manager component size:S 10~30 LoC labels Jan 7, 2025
HyeockJinKim
HyeockJinKim approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@HyeockJinKim HyeockJinKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fregataa fregataa added this pull request to the merge queue Jan 11, 2025
Merged via the queue into main with commit 8bfdf4e Jan 11, 2025
25 checks passed
@fregataa fregataa deleted the fix/simple-query-vfolder-purge-api branch January 11, 2025 06:51
lablup-octodog pushed a commit that referenced this pull request Jan 11, 2025
@fregataa
fix(BA-454): Directly retrieve VFolder by folder ID in purge API (#3388)
419300f 
Backported-from: main (24.12)
Backported-to: 24.09
Backport-of: 3388
@lablup-octodog lablup-octodog mentioned this pull request Jan 11, 2025
Merged
lablup-octodog pushed a commit that referenced this pull request Jan 11, 2025
@fregataa
fix(BA-454): Directly retrieve VFolder by folder ID in purge API (#3388)
d3c8e97 
Backported-from: main (24.12)
Backported-to: 24.03
Backport-of: 3388
@lablup-octodog lablup-octodog mentioned this pull request Jan 11, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 11, 2025
@lablup-octodog @fregataa
fix(BA-454): Directly retrieve VFolder by folder ID in purge API (#3388…
6c442eb 
…) (#3429)

Co-authored-by: Sanghun Lee <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Jan 11, 2025
@lablup-octodog @fregataa
fix(BA-454): Directly retrieve VFolder by folder ID in purge API (#3388…
82f1d93 
…) (#3428)

Co-authored-by: Sanghun Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HyeockJinKim HyeockJinKim HyeockJinKim approved these changes

Assignees

@fregataa fregataa

Labels
area:docs Documentations comp:manager Related to Manager component size:S 10~30 LoC
Projects
None yet
Milestone
24.03
Development

Successfully merging this pull request may close these issues.

Unable to purge vFolder record when the owner user is deleted
2 participants
@fregataa @HyeockJinKim