chore(BA-458): Upgrade pants to 2.23.1 and replace the scie plugin with intrinsic pex option #3377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achimnol
added
area:infrastructure
achimnol
changed the title
achimnol
changed the title
.misc.md -> 3377.misc.md Co-authored-by: octodog <[email protected]>
- a-scie/lift#116 (comment) - Extract repeated scie configurations out to the build macro file
achimnol
force-pushed
the
chore/upgrade-pants-and-retire-scie-plugin
branch
from
3462021 to
f2ded82
Compare
- Also reduce the number of GitHub release files by merging the checksum into a single file.
|
Confirmed the updated workflow step works as expected: |
jsirois
reviewed
Jan 7, 2025
achimnol
added
the
require:pants-export
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3385 (BA-458): This PR upgrades Pantsbuild from 2.21 to 2.23 release, and also upgrades PEX from 2.10 to 2.28.1 alongside. Thanks to https://docs.pex-tool.org/scie.html (a-scie/lift#116), we can now use PEX to build scie binaries.
The new BUILD configs preserve the same command format, so we don't have to update the CI and documentation. Just run the same way:
pants --tag=scie --tag=+lazy package ::.The most significant advantage is that now pants tracks the file changes properly and the scie binaries will be rebuilt if you modify the source files in the working copy, which greatly eases repeated testing of the scie binaries in development setups.
refs #3285 (BA-4): Upgrading Pantsbuild also enables Python 3.13 support added in Pants v2.22.
Additionally, this PR does:
build-sciesjob in the GHA workflow to properly suffix the scie binaries.--scie-name-styleoption to automate this suffix attachment, but it confuses Pantsbuild to pick up the generated output file. Hence, we do the required suffixing by oursevles.scripts/get-platform-suffix.pyfor use in the workflow.build-sciesjob merge the checksums into a single file (checksum.txt) to reduce the number of GitHub release artifacts.pex_binarytargets totools/build-macros.py.ai.backend.account_manager.Checklist: (if applicable)