Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix the newlines of changelog between versions #3364

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

achimnol
Copy link
Member

@achimnol achimnol commented Jan 4, 2025

This PR adds the required newlines to the end of changes/template.md with an explicit comment to prevent accidental removal of them.

The backport target is set to 24.03 which shares the same towncrier version (~=24.8).

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version

@achimnol achimnol added this to the 24.03 milestone Jan 4, 2025
@achimnol achimnol added the area:infrastructure Infrastructure-related issues label Jan 4, 2025
@achimnol achimnol self-assigned this Jan 4, 2025
@achimnol achimnol added the skip:changelog Make the action workflow to skip towncrier check label Jan 4, 2025
@github-actions github-actions bot added the size:XS ~10 LoC label Jan 4, 2025
@achimnol achimnol added this pull request to the merge queue Jan 4, 2025
Merged via the queue into main with commit 5c36498 Jan 4, 2025
28 of 30 checks passed
@achimnol achimnol deleted the ci/fix-towncrier-trailing-newlines branch January 4, 2025 04:34
lablup-octodog pushed a commit that referenced this pull request Jan 4, 2025
Backported-from: main (24.12)
Backported-to: 24.09
Backport-of: 3364
lablup-octodog pushed a commit that referenced this pull request Jan 4, 2025
Backported-from: main (24.12)
Backported-to: 24.03
Backport-of: 3364
github-merge-queue bot pushed a commit that referenced this pull request Jan 4, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:infrastructure Infrastructure-related issues size:XS ~10 LoC skip:changelog Make the action workflow to skip towncrier check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant