Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Resolve some pyright errors #3299

Merged
merged 5 commits into from
Dec 26, 2024
Merged

refactor: Resolve some pyright errors #3299

merged 5 commits into from
Dec 26, 2024

Conversation

achimnol
Copy link
Member

@achimnol achimnol commented Dec 25, 2024 •
edited
Loading

resolves #3298 (BA-412).

  • Fix type definition mismatch of common/enum_extenion.{py,pyi}
  • Fix possibly unbound variables in multiple places
  • Use explicit enum types when possible and fix inconsistent use of enum/str values for MountPermission in get_runner_mount()
  • Use typing.Self in aobject.new()

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue

@achimnol achimnol added this to the 24.09 milestone Dec 25, 2024
@achimnol achimnol added type:refactor Refactor codes or add tests. skip:changelog Make the action workflow to skip towncrier check labels Dec 25, 2024
@achimnol achimnol self-assigned this Dec 25, 2024
@github-actions github-actions bot added comp:agent Related to Agent component comp:common Related to Common component size:M 30~100 LoC labels Dec 25, 2024
@achimnol @rapsealk
fix: typo
02f6e75 
Co-authored-by: Jeongseok Kang <[email protected]>
@achimnol achimnol added this pull request to the merge queue Dec 26, 2024
Merged via the queue into main with commit 7e8632f Dec 26, 2024
21 checks passed
@achimnol achimnol deleted the refactor/resolve-pyright-type-errors branch December 26, 2024 08:35
lablup-octodog pushed a commit that referenced this pull request Dec 26, 2024
@achimnol @rapsealk
refactor: Resolve some pyright errors (#3299)
e7d75e9 
Co-authored-by: Jeongseok Kang <[email protected]>
Backported-from: main (24.12)
Backported-to: 24.09
Backport-of: 3299
github-merge-queue bot pushed a commit that referenced this pull request Dec 26, 2024
@lablup-octodog @achimnol @rapsealk
refactor: Resolve some pyright errors (#3299) (#3301)
60e2d23 
Co-authored-by: Joongi Kim <[email protected]>
Co-authored-by: Jeongseok Kang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rapsealk rapsealk rapsealk left review comments

Assignees

@achimnol achimnol

Labels
comp:agent Related to Agent component comp:common Related to Common component size:M 30~100 LoC skip:changelog Make the action workflow to skip towncrier check type:refactor Refactor codes or add tests.
Projects
None yet
Milestone
24.09
Development

Successfully merging this pull request may close these issues.

Remove some type errors found by pyright
2 participants
@achimnol @rapsealk