Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Change the job name to make sense #3289

Merged
merged 2 commits into from
Dec 24, 2024
Merged

ci: Change the job name to make sense #3289

merged 2 commits into from
Dec 24, 2024

Conversation

Yaminyam
Copy link
Member

@Yaminyam Yaminyam commented Dec 23, 2024

This pull request includes several changes to the .github/workflows/backport.yml file, primarily focusing on renaming the backport-target-branch to get-backport-target-branch in various sections of the workflow.

The most important changes include:

  • Updated the if condition to use needs.get-backport-target-branch.outputs.matrix instead of needs.backport-target-branch.outputs.matrix.
  • Changed the needs dependency from backport-target-branch to get-backport-target-branch.
  • Modified the environment variables and commit message trailers to use get-backport-target-branch outputs instead of backport-target-branch outputs.
  • Updated the author and PR details in the create-pull-request step to use get-backport-target-branch outputs.
  • Adjusted the commit footer to reflect the new get-backport-target-branch naming convention.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version

@github-actions github-actions bot added the size:M 30~100 LoC label Dec 23, 2024
@Yaminyam Yaminyam added this to the 24.12 milestone Dec 23, 2024
@Yaminyam Yaminyam changed the title Update backport.yml ci: Change the job name to make sense Dec 23, 2024
@Yaminyam Yaminyam added the skip:changelog Make the action workflow to skip towncrier check label Dec 23, 2024
@Yaminyam Yaminyam marked this pull request as ready for review December 24, 2024 03:51
@Copilot Copilot bot review requested due to automatic review settings December 24, 2024 03:51
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

.github/workflows/backport.yml Show resolved Hide resolved
@Yaminyam Yaminyam changed the title ci: Change the job name to make sense ci: Change the job name to make sense Dec 24, 2024
@achimnol achimnol added this pull request to the merge queue Dec 24, 2024
Merged via the queue into main with commit 429a1ad Dec 24, 2024
21 of 22 checks passed
@achimnol achimnol deleted the ci/fix-need-job-name branch December 24, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M 30~100 LoC skip:changelog Make the action workflow to skip towncrier check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants