Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: populate BACKEND_MODEL_NAME environment variable automatically #3281

Merged
merged 3 commits into from
Dec 26, 2024

Conversation

kyujin-cho
Copy link
Member

This PR updates model service session creation logic to automatically populate BACKEND_MODEL_NAME as name of the model folder. Handing out the model name as environment variable will help inference runtimes understand the model better.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version

@kyujin-cho kyujin-cho added the type:feature Add new features label Dec 20, 2024
@kyujin-cho kyujin-cho added this to the 24.12 milestone Dec 20, 2024
@kyujin-cho kyujin-cho self-assigned this Dec 20, 2024
@github-actions github-actions bot added comp:manager Related to Manager component size:S 10~30 LoC labels Dec 20, 2024
@kyujin-cho kyujin-cho added the urgency:blocker IT SHOULD BE RESOLVED BEFORE NEXT RELEASE! label Dec 23, 2024
@achimnol achimnol enabled auto-merge December 26, 2024 08:57
@achimnol achimnol added this pull request to the merge queue Dec 26, 2024
Merged via the queue into main with commit 7cd7e7a Dec 26, 2024
20 checks passed
@achimnol achimnol deleted the feature/populate-backend-model-name-env-var branch December 26, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:manager Related to Manager component size:S 10~30 LoC type:feature Add new features urgency:blocker IT SHOULD BE RESOLVED BEFORE NEXT RELEASE!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants