Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Enable per-user UID/GID set for containers #3279

Open
wants to merge 7 commits into
base: topic/12-20-feat_add_uid_and_gid_columns_to_users_and_kernels_tables
Choose a base branch
from
Open

feat: Enable per-user UID/GID set for containers #3279

wants to merge 7 commits into from
+218 −58

Conversation

fregataa
Copy link
Member

@fregataa fregataa commented Dec 20, 2024 •
edited
Loading

When creating a container:

  1. The Manager retrieves the user's container_uid, container_main_gid, and container_supplementary_gids from DB.
  2. These values are then passed to the Agent through the container creation RPC call.
  3. The Agent sets these values as environment variables for the container, allowing entrypoint.sh to run the main executable with the specified UID/GID settings.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version

@fregataa fregataa mentioned this pull request Dec 20, 2024
Open
1 task
@github-actions github-actions bot added comp:manager Related to Manager component comp:agent Related to Agent component comp:common Related to Common component size:L 100~500 LoC labels Dec 20, 2024
@fregataa Graphite App
Copy link
Member Author

fregataa commented Dec 20, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fregataa fregataa force-pushed the topic/12-20-feat_add_uid_and_gid_columns_to_users_and_kernels_tables branch from 6983d4d to 4cd9c9a Compare December 23, 2024 07:04
@fregataa fregataa force-pushed the topic/12-20-feat_enable_per-user_uid_gid_set_for_containers branch from 17482b6 to 0741128 Compare December 23, 2024 07:05
@fregataa fregataa force-pushed the topic/12-20-feat_add_uid_and_gid_columns_to_users_and_kernels_tables branch from 4cd9c9a to f9b0c74 Compare January 2, 2025 06:37
@fregataa fregataa force-pushed the topic/12-20-feat_enable_per-user_uid_gid_set_for_containers branch from 0741128 to f084f97 Compare January 2, 2025 06:37
@github-actions github-actions bot added the require:db-migration Automatically set when alembic migrations are added or updated label Jan 2, 2025
@fregataa fregataa mentioned this pull request Jan 2, 2025
Open
3 tasks
@fregataa fregataa force-pushed the topic/12-20-feat_add_uid_and_gid_columns_to_users_and_kernels_tables branch from f9b0c74 to afd4fce Compare January 2, 2025 10:26
@fregataa fregataa added the skip:changelog Make the action workflow to skip towncrier check label Jan 2, 2025
@fregataa fregataa force-pushed the topic/12-20-feat_enable_per-user_uid_gid_set_for_containers branch from c463435 to 25a6684 Compare January 2, 2025 10:26
@fregataa fregataa added this to the 25Q1 milestone Jan 2, 2025
@fregataa fregataa marked this pull request as ready for review January 2, 2025 10:36
@fregataa fregataa force-pushed the topic/12-20-feat_add_uid_and_gid_columns_to_users_and_kernels_tables branch from afd4fce to b5affba Compare January 3, 2025 07:05
@fregataa fregataa force-pushed the topic/12-20-feat_enable_per-user_uid_gid_set_for_containers branch from 25a6684 to 8687663 Compare January 3, 2025 07:05
@fregataa fregataa force-pushed the topic/12-20-feat_add_uid_and_gid_columns_to_users_and_kernels_tables branch from b5affba to 833a683 Compare January 3, 2025 12:04
@fregataa fregataa force-pushed the topic/12-20-feat_enable_per-user_uid_gid_set_for_containers branch from 8687663 to e4b9ddd Compare January 3, 2025 12:04
@fregataa fregataa mentioned this pull request Jan 3, 2025
Open
2 tasks
@fregataa fregataa force-pushed the topic/12-20-feat_add_uid_and_gid_columns_to_users_and_kernels_tables branch from 833a683 to c733959 Compare January 6, 2025 03:43
@fregataa fregataa force-pushed the topic/12-20-feat_enable_per-user_uid_gid_set_for_containers branch from e4b9ddd to 72160a4 Compare January 6, 2025 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fregataa fregataa

Labels
comp:agent Related to Agent component comp:common Related to Common component comp:manager Related to Manager component require:db-migration Automatically set when alembic migrations are added or updated size:L 100~500 LoC skip:changelog Make the action workflow to skip towncrier check
Projects
None yet
Milestone
25Q1
Development

Successfully merging this pull request may close these issues.
1 participant
@fregataa