Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix matrix variable to use target_branches #3274

Merged
merged 5 commits into from
Dec 19, 2024

Conversation

Yaminyam
Copy link
Member

@Yaminyam Yaminyam commented Dec 19, 2024

This pull request includes changes to the .github/workflows/backport.yml file to enhance the handling of environment variables and improve the matrix generation logic.

Improvements to environment variable handling:

  • .github/workflows/backport.yml: Added an environment variable COMMITS to store the JSON representation of GitHub event commits, simplifying the retrieval of commit IDs.

Enhancements to matrix generation logic:

  • .github/workflows/backport.yml: Changed the matrix generation to use target_branches instead of target_milestones, ensuring the correct branches are targeted for the backport process.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version

@Copilot Copilot bot review requested due to automatic review settings December 19, 2024 05:44
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

.github/workflows/backport.yml Show resolved Hide resolved
@github-actions github-actions bot added the size:XS ~10 LoC label Dec 19, 2024
@Yaminyam Yaminyam added this to the 24.12 milestone Dec 19, 2024
@Yaminyam Yaminyam changed the title ci: backport to handle commit messages safely ci: Fix matrix variable to use target_branches Dec 19, 2024
@Yaminyam Yaminyam added the skip:changelog Make the action workflow to skip towncrier check label Dec 19, 2024
@Yaminyam Yaminyam requested a review from achimnol December 19, 2024 05:55
Copy link
Member

@achimnol achimnol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to clarify the descriptions further. 😉

.github/workflows/backport.yml Outdated Show resolved Hide resolved
.github/workflows/backport.yml Outdated Show resolved Hide resolved
@achimnol achimnol enabled auto-merge December 19, 2024 06:06
@achimnol achimnol added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit c19d92b Dec 19, 2024
20 checks passed
@achimnol achimnol deleted the ci/fix-stacked-pr-backport branch December 19, 2024 06:10
achimnol added a commit that referenced this pull request Dec 20, 2024
achimnol added a commit that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS ~10 LoC skip:changelog Make the action workflow to skip towncrier check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants