chore: Update gitignore to exclude alembic.ini for account manager #3268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregataa
changed the title
There was a problem hiding this comment.
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
Files not reviewed (1)
- am-alembic.ini: Language not supported
fregataa
added
the
skip:changelog
achimnol
changed the title
|
I don't understand why we have to add this specific pattern to gitignore. |
achimnol
force-pushed
the
fix/update-gitignore-to-exclude-alembic
branch
from
590ac38 to
431d2ab
Compare
|
After inspecting the code history, I found that As future work, we would need to move the location of generated config files to a sub-directory to avoid conflicts of the same configuration files used in different service daemons. |
achimnol
changed the title
|
Backport to is failed. Please backport manually. |
achimnol
added a commit
that referenced
this pull request
Dec 20, 2024
Co-authored-by: Joongi Kim <[email protected]>
lablup-octodog
pushed a commit
that referenced
this pull request
Dec 27, 2024
Co-authored-by: Joongi Kim <[email protected]> Backported-from: main (24.12) Backported-to: 24.09 Backport-of: 3268
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 27, 2024
Co-authored-by: Sanghun Lee <[email protected]> Co-authored-by: Joongi Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #2689
.gitignoreto excludealembic-accountmgr.iniconfig fileinstall-dev.shto installalembic-accountmgr.iniinstead ofam-alembic.iniusing a more clear file nameam-alembic.iniconfig fileChecklist: (if applicable)