ci: Separate the kvstore's response body and status code #3265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
.github/workflows/backport.yml:105
- Ensure that the new behavior of checking the HTTP status code using STATUS_CODE is covered by tests.
if [ $STATUS_CODE == "404" ]; then
Yaminyam
added
the
skip:changelog
…265.feature.md Co-authored-by: octodog <[email protected]>
achimnol
approved these changes
Dec 19, 2024
achimnol
pushed a commit
that referenced
this pull request
Dec 20, 2024
Co-authored-by: octodog <[email protected]>
achimnol
pushed a commit
that referenced
this pull request
Dec 20, 2024
Co-authored-by: octodog <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a change to the
jobssection in the.github/workflows/backport.ymlfile to improve the handling of HTTP status codes in the backport workflow.Improvements to HTTP status code handling:
.github/workflows/backport.yml: Replaced theresponsevariable withSTATUS_CODEto store the HTTP status code directly. This change ensures that the script checks the status code correctly when determining the target branches for backporting.Checklist: (if applicable)