Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not reuse Base class on alembic migration script #3254

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

kyujin-cho
Copy link
Member

@kyujin-cho kyujin-cho commented Dec 16, 2024

Table definition on alembic migration script should remain independently and should not be affected by the definitions declared at ai.backend.manager.models package. This update alters existing database migration script but won't change the schema itself, so existing users do not have to take extra steps.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version

@github-actions github-actions bot added comp:manager Related to Manager component require:db-migration Automatically set when alembic migrations are added or updated size:XS ~10 LoC labels Dec 16, 2024
@kyujin-cho kyujin-cho added this to the 24.09 milestone Dec 16, 2024
@kyujin-cho kyujin-cho enabled auto-merge December 16, 2024 08:51
@kyujin-cho kyujin-cho added this pull request to the merge queue Dec 16, 2024
Merged via the queue into main with commit 7079a8e Dec 16, 2024
23 checks passed
@kyujin-cho kyujin-cho deleted the fix/do-not-reuse-base branch December 16, 2024 08:54
lablup-octodog pushed a commit that referenced this pull request Dec 16, 2024
Backported-from: main (24.12)
Backported-to: 24.09
Backport-of: 3254
github-merge-queue bot pushed a commit that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:manager Related to Manager component require:db-migration Automatically set when alembic migrations are added or updated size:XS ~10 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant