fix: Prevent vfolder request-download API from accessing host filesystem
#3241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
comp:storage-proxy
jopemachine
force-pushed
the
fix/vfolder-host-file-download-vulnerability
branch
from
5f95026 to
6efb3f0
Compare
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
HyeockJinKim
deleted the
fix/vfolder-host-file-download-vulnerability
branch
lablup-octodog
pushed a commit
that referenced
this pull request
Dec 13, 2024
…ystem (#3241) Backported-from: main (24.12) Backported-to: 24.03 Backport-of: 3241
lablup-octodog
pushed a commit
that referenced
this pull request
Dec 13, 2024
…ystem (#3241) Backported-from: main (24.12) Backported-to: 24.09 Backport-of: 3241
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
…ystem (#3241) (#3245) Co-authored-by: Gyubong Lee <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
…ystem (#3241) (#3246) Co-authored-by: Gyubong Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/lablup/giftbox/issues/786.
The existing VFolder
request-downloadAPI could download files outside of the vfolder.For example, using the vfolder CLI command that utilizes this API, we can download host files as shown below.
This is clearly a security vulnerability, as it can be exploited, for example, as shown in issue 786.
After applying the PR, passing a path outside the VFolder will result in a 404 error.
Thanks to @fregataa for resolving this issue.
Checklist: (if applicable)