Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Deprecate non relay container registry GQL explicitly #3231

Merged
merged 3 commits into from
Jan 14, 2025
Merged

doc: Deprecate non relay container registry GQL explicitly #3231

merged 3 commits into from
Jan 14, 2025

Conversation

jopemachine
Copy link
Member

@jopemachine jopemachine commented Dec 9, 2024 •
edited by github-actions bot
Loading

Mark the ContainerRegistry GQL API as deprecated since 24.09.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version

📚 Documentation preview 📚: https://sorna--3231.org.readthedocs.build/en/3231/

📚 Documentation preview 📚: https://sorna-ko--3231.org.readthedocs.build/ko/3231/

@jopemachine jopemachine added skip:changelog Make the action workflow to skip towncrier check skip:ci Make the action workflow to skip running lint, check, and test (use with caution!) labels Dec 9, 2024
@jopemachine jopemachine added this to the 24.09 milestone Dec 9, 2024
@jopemachine jopemachine self-assigned this Dec 9, 2024
@jopemachine jopemachine changed the title fix: Deprecate non relay container registry API explicitly doc: Deprecate non relay container registry API explicitly Dec 9, 2024
@jopemachine jopemachine added area:docs Documentations and removed skip:changelog Make the action workflow to skip towncrier check labels Dec 9, 2024
@jopemachine jopemachine changed the title doc: Deprecate non relay container registry API explicitly doc: Deprecate non relay container registry GQL explicitly Dec 9, 2024
@jopemachine jopemachine marked this pull request as ready for review December 9, 2024 09:46
HyeockJinKim
HyeockJinKim reviewed Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@HyeockJinKim HyeockJinKim left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any related discussion? If so, I will merge it right away. @jopemachine

@jopemachine
Copy link
Member Author

Is there any related discussion? If so, I will merge it right away. @jopemachine

Yes, please refer to the Teams thread that I mentioned.

@jopemachine jopemachine force-pushed the fix/deprecate-container-registry-api branch from 0be5c5b to c9a8866 Compare December 30, 2024 01:50
@jopemachine
Copy link
Member Author

@HyeockJinKim Could you review the PR again and confirm if it's ready to be merged?

@github-actions github-actions bot added comp:manager Related to Manager component size:M 30~100 LoC labels Dec 30, 2024
HyeockJinKim
HyeockJinKim approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@HyeockJinKim HyeockJinKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jopemachine jopemachine force-pushed the fix/deprecate-container-registry-api branch from c9a8866 to f27e967 Compare January 14, 2025 11:40
@jopemachine jopemachine added this pull request to the merge queue Jan 14, 2025
@jopemachine jopemachine removed this pull request from the merge queue due to a manual request Jan 14, 2025
@github-actions github-actions bot added size:L 100~500 LoC and removed size:M 30~100 LoC labels Jan 14, 2025
@jopemachine jopemachine enabled auto-merge January 14, 2025 11:48
@jopemachine jopemachine added this pull request to the merge queue Jan 14, 2025
@jopemachine jopemachine removed this pull request from the merge queue due to a manual request Jan 14, 2025
@jopemachine jopemachine force-pushed the fix/deprecate-container-registry-api branch from 06f9515 to f27e967 Compare January 14, 2025 11:49
@jopemachine jopemachine enabled auto-merge January 14, 2025 11:49
@github-actions github-actions bot added size:M 30~100 LoC and removed size:L 100~500 LoC labels Jan 14, 2025
@jopemachine jopemachine added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit 76f646c Jan 14, 2025
37 of 39 checks passed
@jopemachine jopemachine deleted the fix/deprecate-container-registry-api branch January 14, 2025 11:53
lablup-octodog pushed a commit that referenced this pull request Jan 14, 2025
@jopemachine
doc: Deprecate non relay container registry GQL explicitly (#3231)
cec74db 
Backported-from: main (24.12)
Backported-to: 24.09
Backport-of: 3231
@lablup-octodog lablup-octodog mentioned this pull request Jan 14, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 14, 2025
@lablup-octodog @jopemachine
doc: Deprecate non relay container registry GQL explicitly (#3231) (#…
f57f392 
…3456)

Co-authored-by: Gyubong Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HyeockJinKim HyeockJinKim HyeockJinKim approved these changes

@fregataa fregataa Awaiting requested review from fregataa

@kyujin-cho kyujin-cho Awaiting requested review from kyujin-cho

Assignees

@jopemachine jopemachine

Labels
area:docs Documentations comp:manager Related to Manager component size:M 30~100 LoC skip:ci Make the action workflow to skip running lint, check, and test (use with caution!)
Projects
None yet
Milestone
24.09
Development

Successfully merging this pull request may close these issues.
2 participants
@jopemachine @HyeockJinKim