Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Make it possible to backport multiple commits #3193

Merged
merged 4 commits into from
Dec 9, 2024

Conversation

Yaminyam
Copy link
Member

@Yaminyam Yaminyam commented Dec 4, 2024

close #3192
Change the matrix to backport all commits, even if multiple commits are pushed at once using the merge queue.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version

@Yaminyam Yaminyam added this to the 24.12 milestone Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (1)

.github/workflows/backport.yml:22

  • [nitpick] The variable name 'commits_json' is ambiguous. It should be renamed to 'commits_array_json' to clearly indicate it's an array in JSON format.
commits_json=$(jq -nc --arg commits "$commits" '$commits | split("\n") | map(select(length > 0))')
@github-actions github-actions bot added the size:S 10~30 LoC label Dec 4, 2024
@Yaminyam Yaminyam added the skip:changelog Make the action workflow to skip towncrier check label Dec 4, 2024
@Yaminyam Yaminyam requested a review from Copilot December 6, 2024 06:54

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

@achimnol achimnol added this pull request to the merge queue Dec 9, 2024
Merged via the queue into main with commit 3968538 Dec 9, 2024
20 checks passed
@achimnol achimnol deleted the ci/backport-multiple-commits branch December 9, 2024 15:35
Copy link

github-actions bot commented Dec 9, 2024

Backport to is failed. Please backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S 10~30 LoC skip:changelog Make the action workflow to skip towncrier check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only one backport will work for multiple commit pushes at the same time
2 participants