fix: Do not multiply session occupying slots #3186
Merged
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
comp:manager
fregataa
changed the title
HyeockJinKim
reviewed
Dec 4, 2024
| session_occupying_slots = ResourceSlot.from_json({**session_row.occupying_slots}) | ||
| session_occupying_slots = ResourceSlot() |
There was a problem hiding this comment.
The current code seems a bit tricky to write test code... 😢
Have you tried verifying that it works?
lablup-octodog
pushed a commit
that referenced
this pull request
Dec 6, 2024
Backported-from: main (24.12) Backported-to: 24.09 Backport-of: 3186
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
Co-authored-by: Sanghun Lee <[email protected]> Co-authored-by: Kyujin Cho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3187
Whenever
_transit_session_status()is called, it accumulates session's occupying slotsChecklist: (if applicable)