Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow purging vfolders by enabling querying deleted vfolders by name #3176

Merged
merged 4 commits into from
Dec 6, 2024

Conversation

fregataa
Copy link
Member

@fregataa fregataa commented Nov 29, 2024

resolves #3181 https://github.com/lablup/giftbox/issues/780

The purge SDK function first queries by name to find the ID of the VFolders to be removed, but the API (get_vfolder_id) could not query folders in delete-complete status.
We are modifying the get_vfolder_id API to enable querying VFolders in all statuses

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • API server-client counterparts (e.g., manager API -> client SDK)

📚 Documentation preview 📚: https://sorna--3176.org.readthedocs.build/en/3176/


📚 Documentation preview 📚: https://sorna-ko--3176.org.readthedocs.build/ko/3176/

Sorry, something went wrong.

@fregataa fregataa added this to the 24.03 milestone Nov 29, 2024
@fregataa fregataa self-assigned this Nov 29, 2024
@github-actions github-actions bot added area:docs Documentations comp:manager Related to Manager component size:XS ~10 LoC labels Nov 29, 2024
@fregataa fregataa changed the title fix: allow purge vfolders by passing status to precond check function fix: Allow purging vfolders by enabling querying deleted vfolders by name Nov 29, 2024
@fregataa fregataa requested a review from adrysn November 30, 2024 07:12
Copy link
Member

@adrysn adrysn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied the changes, but the issue persists. Could it be that the superadmin's email doesn't match the vfolder owner's email?

@fregataa
Copy link
Member Author

fregataa commented Dec 2, 2024

I applied the changes, but the issue persists. Could it be that the superadmin's email doesn't match the vfolder owner's email?

Do you get the same 404 error after this change?

@fregataa fregataa requested a review from adrysn December 5, 2024 08:34
@kyujin-cho kyujin-cho added this pull request to the merge queue Dec 6, 2024
Merged via the queue into main with commit 32e08cd Dec 6, 2024
28 checks passed
@kyujin-cho kyujin-cho deleted the fix/allow-purge-vfolders-by-passing-allowed-status branch December 6, 2024 12:54
lablup-octodog pushed a commit that referenced this pull request Dec 6, 2024
…name (#3176)

Backported-from: main (24.12)
Backported-to: 24.03
Backport-of: 3176
lablup-octodog pushed a commit that referenced this pull request Dec 6, 2024
…name (#3176)

Backported-from: main (24.12)
Backported-to: 24.09
Backport-of: 3176
github-merge-queue bot pushed a commit that referenced this pull request Dec 6, 2024
…name (#3176) (#3219)

Co-authored-by: Sanghun Lee <sanghun@lablup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:docs Documentations comp:manager Related to Manager component size:XS ~10 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to purge VFolders
3 participants