fix: program not started when rotation-size is set
#3174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyujin-cho
added a commit
that referenced
this pull request
Nov 28, 2024
Backported-from: main (24.12) Backported-to: 24.09 Backport-of: 3174
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #2760. For unknown reason, we see that the server tries to reiterate value already converted to integer to
SimpleBinarySizeTrafaretwhen validating[logging].rotation-sizeconfiguration. For immediate workaround I suppose it is best to allow integer also as a valid data type forSimpleBinarySizeTrafaret- in this case the validator will act as a no-op and just return the fed data.Checklist: (if applicable)