chore: Correct typos and change agent selector plugin config key to kebab-case #2846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
comp:manager
jopemachine
added
the
skip:changelog
jopemachine
changed the title
agent selector config key to kebab case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #1655.
Details
Fix several typos.
Change snake case mistakenly used in Etcd configuration key.
ResourceGroupState->AbstractResourceGroupState.: Abstract type names should start with Abstract, similar to other types.
Move the type declarations for
RoundRobinStateandRRAgentSelectorState.: These types would be better placed in
types.py.Checklist: (if applicable)