fix: Handle all possible exceptions when scheduling single node session #2411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
comp:manager
Your org has enabled the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
…duling-singlenode-session
…duling-singlenode-session
achimnol
approved these changes
Jul 15, 2024
|
I don't think this will fix all "pending-but-no-reason" cases, but the logic of fix is correct. Thanks! |
achimnol
deleted the
fix/handle-all-possible-exceptions-when-scheduling-singlenode-session
branch
lablup-octodog
pushed a commit
that referenced
this pull request
Jul 15, 2024
…on (#2411) Co-authored-by: Joongi Kim <[email protected]> Backported-from: main (24.09) Backported-to: 24.03 Backport-of: 2411
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 15, 2024
…on (#2411) (#2476) Co-authored-by: Sanghun Lee <[email protected]> Co-authored-by: Joongi Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up #643 #2155
refs https://github.com/lablup/giftbox/issues/691
manager's scheduler does not handle some of
GenericBadRequestexceptions raised in_schedule_single_node_session(), which make status information empty for some pending sessions.Checklist: (if applicable)