Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cannot resolve model_card GQL query #2161

Merged
merged 17 commits into from
Jul 1, 2024
Merged

fix: Cannot resolve model_card GQL query #2161

merged 17 commits into from
Jul 1, 2024

Conversation

fregataa
Copy link
Member

@fregataa fregataa commented May 21, 2024

follow-up #1749

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • API server-client counterparts (e.g., manager API -> client SDK)

@fregataa fregataa self-assigned this May 21, 2024
Copy link

graphite-app bot commented May 21, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added comp:manager Related to Manager component size:XS ~10 LoC labels May 21, 2024
@fregataa fregataa requested a review from yomybaby June 25, 2024 06:40
@github-actions github-actions bot added size:S 10~30 LoC and removed size:XS ~10 LoC labels Jun 25, 2024
@github-actions github-actions bot added size:M 30~100 LoC and removed size:S 10~30 LoC labels Jun 27, 2024
@fregataa fregataa changed the title feature: Update for model store fix: Cannot resolve model_card GQL query Jun 27, 2024
@fregataa fregataa marked this pull request as ready for review June 27, 2024 05:55
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ironAiken2 pushed a commit to lablup/backend.ai-webui that referenced this pull request Jul 1, 2024
> [!CAUTION]
> This PR should be merged after  lablup/backend.ai#2161

This PR includes

- Background task notification for cloning a model folder
- Modify frontend components to reflect schema changes and improve user interaction with vFolders.
- Update internationalization files to include messages related to folder cloning and handling errors in multiple languages.

## How to Test
- Make sure related core PR: lablup/backend.ai#2161
- Create a 'model' project folder in the 'model-store' project.
- Upload `model-definition.yml`.
  - [model-definition.yml.zip](https://github.com/user-attachments/files/15982404/model-definition.yml.zip)
- Navigate to the model store list on the `/data` page.
- Click on a model card item and then click the "Clone" button.
- You should see the notification and the cloned 'model' folder in the model tab of the `/data` page.

<!--
Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes,
and how it affects the users and other developers.
-->

**Checklist:** (if applicable)

- [ ] Mention to the original issue
- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after
@fregataa fregataa requested a review from yomybaby July 1, 2024 07:10
@fregataa fregataa enabled auto-merge (squash) July 1, 2024 07:55
@fregataa fregataa disabled auto-merge July 1, 2024 07:57
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yomybaby yomybaby self-requested a review July 1, 2024 08:18
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fregataa fregataa merged commit 266f128 into main Jul 1, 2024
31 checks passed
@fregataa fregataa deleted the feature/model-store branch July 1, 2024 08:24
@kyujin-cho kyujin-cho modified the milestones: 24.09, 24.03 Jul 8, 2024
kyujin-cho pushed a commit that referenced this pull request Jul 8, 2024
Co-authored-by: Joongi Kim <[email protected]>
Backported-from: 24.09 (main)
Backported-to: 24.03
Backport-of: 2161
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:manager Related to Manager component size:M 30~100 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants