-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Cannot resolve model_card
GQL query
#2161
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
model_card
GQL query
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
> [!CAUTION] > This PR should be merged after lablup/backend.ai#2161 This PR includes - Background task notification for cloning a model folder - Modify frontend components to reflect schema changes and improve user interaction with vFolders. - Update internationalization files to include messages related to folder cloning and handling errors in multiple languages. ## How to Test - Make sure related core PR: lablup/backend.ai#2161 - Create a 'model' project folder in the 'model-store' project. - Upload `model-definition.yml`. - [model-definition.yml.zip](https://github.com/user-attachments/files/15982404/model-definition.yml.zip) - Navigate to the model store list on the `/data` page. - Click on a model card item and then click the "Clone" button. - You should see the notification and the cloned 'model' folder in the model tab of the `/data` page. <!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> **Checklist:** (if applicable) - [ ] Mention to the original issue - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Joongi Kim <[email protected]> Backported-from: 24.09 (main) Backported-to: 24.03 Backport-of: 2161
follow-up #1749
Checklist: (if applicable)