Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add session tag in key-value format #1851

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

Yaminyam
Copy link
Member

close #390
The session tag function, which previously saved text like a regular memo, can now be saved in key-value format.
The key is limited to a maximum of 128 characters, and the value is limited to a maximum of 256 characters.
Input requires the form 'key1=value1, key2=value2, ...'.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates including:
    • Fixtures for db schema changes
    • New mandatory config options
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

@Yaminyam Yaminyam marked this pull request as draft January 19, 2024 06:14
@github-actions github-actions bot added area:ux UI / UX issue. comp:cli Related to CLI component comp:client Related to Client component comp:manager Related to Manager component effort:easy Need to understand only a specific region of codes (good first issue, easy). type:feature Add new features size:M 30~100 LoC labels Jan 19, 2024
@github-actions github-actions bot added this to the 24.03 milestone Apr 4, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using(or updating) ai.backend.cli.params.CommaSeparatedKVListParamType?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have customized column schemas in ai.backend.manager.models.base.
It will be good for performance to set a constraint in SQL but how about making(or updating) a column schema?
ai.backend.manager.models.base.StructuredJSONColumn would work but it might need update.

@Yaminyam Yaminyam marked this pull request as ready for review April 5, 2024 05:55
@Yaminyam Yaminyam marked this pull request as draft April 5, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ux UI / UX issue. comp:cli Related to CLI component comp:client Related to Client component comp:manager Related to Manager component effort:easy Need to understand only a specific region of codes (good first issue, easy). size:M 30~100 LoC type:feature Add new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tags for compute sessions
2 participants