fix: Fill vfolder user and group field #1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
comp:manager
kyujin-cho
approved these changes
Jan 12, 2024
Comment on lines
+1126
to
+1140
| def _get_field(name: str) -> Any: | ||
| try: | ||
| return row[name] | ||
| except sa.exc.NoSuchColumnError: | ||
| return None | ||
|
|
||
| return cls( | ||
| id=row["id"], | ||
| host=row["host"], | ||
| quota_scope_id=row["quota_scope_id"], | ||
| name=row["name"], | ||
| user=row["user"], | ||
| user_email=row["users_email"] if "users_email" in row else None, | ||
| user_email=_get_field("users_email"), | ||
| group=row["group"], | ||
| group_name=row["groups_name"] if "groups_name" in row else None, | ||
| group_name=_get_field("groups_name"), |
There was a problem hiding this comment.
Let's merge this for now, but please consider revamping whole column lookup logic as guarding NoSuchColumnError like here may confuse future maintainers when they accidentally failed to include column to their SELECT query.
kyujin-cho
added a commit
that referenced
this pull request
Jan 12, 2024
Co-authored-by: Kyujin Cho <[email protected]> Backported-from: main Backported-to: 23.09
kyujin-cho
added a commit
that referenced
this pull request
Feb 21, 2024
Co-authored-by: Kyujin Cho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: (if applicable)
ai.backend.testdocsdirectory