Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update session's occupying slots when kernel starts #1832

Merged
merged 20 commits into from
Jun 16, 2024
Merged

fix: update session's occupying slots when kernel starts #1832

merged 20 commits into from
Jun 16, 2024

Conversation

fregataa
Copy link
Member

@fregataa fregataa commented Jan 10, 2024 •
edited
Loading

resolves https://github.com/lablup/giftbox/issues/602

image
  • Update sessions table's occupying_slots field with kernel's actual resource allocation
  • convert_resource_spec_to_resource_slot() method changed because it converts all values into str, which is unable to add to other resource slots. This WILL NOT change the value saved in DB because ResourceSlotColumn converts numeric values into string when ResourceSlot data is saved.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation

@fregataa fregataa added this to the 24.03 milestone Jan 10, 2024
@fregataa fregataa requested a review from adrysn January 10, 2024 08:22
@fregataa fregataa self-assigned this Jan 10, 2024
@github-actions github-actions bot added comp:manager Related to Manager component size:M 30~100 LoC labels Jan 10, 2024
@fregataa fregataa added the urgency:4 As soon as feasible, implementation is essential. label Jan 10, 2024
@github-actions github-actions bot added size:L 100~500 LoC and removed size:M 30~100 LoC labels Mar 29, 2024
@github-actions github-actions bot added the require:db-migration Automatically set when alembic migrations are added or updated label Apr 1, 2024
@fregataa fregataa modified the milestones: 24.03, 24.09 Apr 4, 2024
@fregataa fregataa modified the milestones: 24.09, 24.03 Apr 5, 2024
@github-actions github-actions bot added the comp:common Related to Common component label Jun 10, 2024
@fregataa fregataa requested review from achimnol and kyujin-cho June 10, 2024 01:46
kyujin-cho
kyujin-cho requested changes Jun 16, 2024
View reviewed changes
src/ai/backend/manager/models/session.py Outdated Show resolved Hide resolved
src/ai/backend/manager/models/session.py Outdated Show resolved Hide resolved
@fregataa fregataa requested a review from kyujin-cho June 16, 2024 04:08
@kyujin-cho kyujin-cho enabled auto-merge (squash) June 16, 2024 04:16
@kyujin-cho kyujin-cho merged commit 0805293 into main Jun 16, 2024
23 of 29 checks passed
@kyujin-cho kyujin-cho deleted the fix/session-occupying-slot-update branch June 16, 2024 04:30
kyujin-cho added a commit that referenced this pull request Jun 16, 2024
@fregataa @kyujin-cho
fix: update session's occupying slots when kernel starts (#1832)
9608cb8 
Co-authored-by: Kyujin Cho <[email protected]>
Backported-from: main (24.09)
Backported-to: 24.03
Backport-of: 1832
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrysn adrysn Awaiting requested review from adrysn

@achimnol achimnol Awaiting requested review from achimnol

@kyujin-cho kyujin-cho Awaiting requested review from kyujin-cho

Assignees

@fregataa fregataa

Labels
comp:common Related to Common component comp:manager Related to Manager component require:db-migration Automatically set when alembic migrations are added or updated size:L 100~500 LoC urgency:4 As soon as feasible, implementation is essential.
Projects
None yet
Milestone
24.03
Development

Successfully merging this pull request may close these issues.
2 participants
@fregataa @kyujin-cho