Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make metadata field of model definition optional #1825

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

kyujin-cho
Copy link
Member

Follow-up PR of #1749. This PR adds a default value of metadata config schema so that it can really be treated as an optional value.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue

@kyujin-cho kyujin-cho self-assigned this Jan 8, 2024
@github-actions github-actions bot added the size:XS ~10 LoC label Jan 8, 2024
@kyujin-cho kyujin-cho added this to the 24.03 milestone Jan 8, 2024
@kyujin-cho kyujin-cho added the skip:changelog Make the action workflow to skip towncrier check label Jan 8, 2024
@kyujin-cho kyujin-cho enabled auto-merge January 8, 2024 06:21
@kyujin-cho kyujin-cho added this pull request to the merge queue Jan 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2024
@kyujin-cho kyujin-cho added this pull request to the merge queue Jan 10, 2024
Merged via the queue into main with commit b835aff Jan 10, 2024
38 of 39 checks passed
@kyujin-cho kyujin-cho deleted the fix/model-service-validation-failure branch January 10, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS ~10 LoC skip:changelog Make the action workflow to skip towncrier check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant