Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Key mismatch for registry URL in ModifyContainerRegistry mutation #1810

Merged
merged 3 commits into from
Dec 26, 2023

Conversation

rapsealk
Copy link
Member

@rapsealk rapsealk commented Dec 26, 2023

This PR is a follow-up of #1471 and resolves #1808.

An issue has been identified in the ModifyContainerRegistry mutation, where the url field was not updating as intended. The problem stemmed from a key mismatch: while the GraphQL input field uses url, the etcd uses an empty string ("") for the registry URL. This update addresses the issue by modifying the key from url to an empty string ("") if it exists.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates including:
    • Fixtures for db schema changes
    • New mandatory config options
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

@rapsealk rapsealk added the type:bug Reports about that are not working label Dec 26, 2023
@rapsealk rapsealk added this to the 23.09 milestone Dec 26, 2023
@rapsealk rapsealk requested a review from lizable December 26, 2023 04:53
@rapsealk rapsealk self-assigned this Dec 26, 2023
@github-actions github-actions bot added the comp:manager Related to Manager component label Dec 26, 2023
@rapsealk rapsealk added action:on hold Hold it. Wait for the restart. and removed comp:manager Related to Manager component labels Dec 26, 2023
@github-actions github-actions bot added the size:S 10~30 LoC label Dec 26, 2023
@rapsealk rapsealk removed the action:on hold Hold it. Wait for the restart. label Dec 26, 2023
@rapsealk rapsealk added action:on hold Hold it. Wait for the restart. and removed action:on hold Hold it. Wait for the restart. labels Dec 26, 2023
Copy link
Contributor

@lizable lizable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lizable lizable added this pull request to the merge queue Dec 26, 2023
Merged via the queue into main with commit 570354e Dec 26, 2023
21 checks passed
@lizable lizable deleted the fix/etcd-container-registry-modify-url branch December 26, 2023 06:18
lizable pushed a commit that referenced this pull request Dec 27, 2023
…ion (#1810) Backported-from: main, Backported-to: 23.09
lizable pushed a commit that referenced this pull request Dec 27, 2023
…ion (#1810)

Backported-from: main
Backported-to: 23.09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S 10~30 LoC type:bug Reports about that are not working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Registry modification doesn't work properly
2 participants