Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Pants installation path from ~/bin to ~/.local/bin #1806

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

hoyajigi
Copy link
Member

@hoyajigi hoyajigi commented Dec 22, 2023

resolves #1751

due to the recent changes in pants install script, the install directory of pants changed to ~/.local/bin

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates

@github-actions github-actions bot added the type:bug Reports about that are not working label Dec 22, 2023
@github-actions github-actions bot added the size:XS ~10 LoC label Dec 22, 2023
@hoyajigi hoyajigi marked this pull request as ready for review December 22, 2023 07:42
@hoyajigi hoyajigi requested a review from achimnol December 26, 2023 02:19
Copy link
Member

@achimnol achimnol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!
Please add a news fragment file (check out other merged PRs about how to name & write it).

@achimnol achimnol added the comp:installer Related to Installer label Dec 27, 2023
@achimnol achimnol modified the milestones: 23.09, 23.03 Dec 27, 2023
@hoyajigi
Copy link
Member Author

@achimnol Done!

@studioego studioego self-requested a review January 8, 2024 04:44
@studioego
Copy link
Contributor

I found the issue on Raspberry Pi5 with Debian OS.
image

I checked the fix codes.

However, If $HOME/.local/bin is not in $PATH, I've checked that the error is as follows
(not found pants on PATH)
image

@studioego
Copy link
Contributor

studioego commented Jan 8, 2024

Hmm. I found the PATH on the $HOME/.profile file.

after run the

source ~/.profile

then, It can run pants.

I think that LGTM

@studioego
Copy link
Contributor

LGTM!
It works good on Raspberry pi 5.

image

Copy link
Contributor

@studioego studioego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works on Raspberry pi5
image

@achimnol achimnol changed the title Fix: Pants install directory changed from ~/bin to ~/.local/bin fix: Update Pants installation path from ~/bin to ~/.local/bin Jan 9, 2024
@achimnol achimnol enabled auto-merge January 9, 2024 01:21
@achimnol achimnol added this pull request to the merge queue Jan 9, 2024
Merged via the queue into main with commit c4a0120 Jan 9, 2024
25 checks passed
@achimnol achimnol deleted the fix/pants-local-install-directory branch January 9, 2024 01:25
achimnol added a commit that referenced this pull request Jan 9, 2024
…1806)

Backported-from: main
Backported-to: 23.09
Co-authored-by: Joongi Kim <[email protected]>
kyujin-cho pushed a commit that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:installer Related to Installer size:XS ~10 LoC type:bug Reports about that are not working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pants install directory needs change in install-dev.sh
3 participants