Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove the containers entry from session list --format #1766

Merged
merged 4 commits into from
Dec 7, 2023

Conversation

Yaminyam
Copy link
Member

@Yaminyam Yaminyam commented Dec 7, 2023

The containers item with another table information in the session list output in table format makes the output very awkward.

CleanShot 2023-12-07 at 17 55 51@2x CleanShot 2023-12-07 at 17 56 53@2x

This makes it difficult to keep track of the session list.

If you want to output containers information, you can do so using session info.

@Yaminyam Yaminyam requested review from achimnol and fregataa December 7, 2023 08:58
@github-actions github-actions bot added comp:client Related to Client component size:XS ~10 LoC labels Dec 7, 2023
Copy link
Member

@achimnol achimnol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. 👍🏼

@achimnol achimnol added this to the 23.09 milestone Dec 7, 2023
@achimnol achimnol enabled auto-merge December 7, 2023 09:16
@achimnol achimnol added this pull request to the merge queue Dec 7, 2023
Merged via the queue into main with commit 0698ea9 Dec 7, 2023
22 checks passed
@achimnol achimnol deleted the fix/sessino-list-remove-containers branch December 7, 2023 09:23
achimnol added a commit that referenced this pull request Dec 7, 2023
Backported-from: main
Backported-to: 23.09
Co-authored-by: Joongi Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:client Related to Client component size:XS ~10 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants