Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use ui.menu_blocklist to hide and ui.menu_inactivelist to disable menu items #1733

Merged
merged 4 commits into from
Dec 13, 2023
Merged

feat: Use ui.menu_blocklist to hide and ui.menu_inactivelist to disable menu items #1733

merged 4 commits into from
Dec 13, 2023

Conversation

rapsealk
Copy link
Member

This PR is a follow-up on #1727 and counterparts against lablup/backend.ai-webui#2040

This PR updates webserver configs:

  • Use ui.menu_blocklist to hide menu items (previous behavior: disable)
  • Use ui.menu_inactivelist to disable menu items

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Documentation
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to demonstrate the difference of before/after

@rapsealk rapsealk added area:ux UI / UX issue. comp:webui Related to WebUI component urgency:2 With time limit, it should be finished within it; otherwise, resolve it when no other chores. labels Nov 23, 2023
@rapsealk rapsealk added this to the 23.09 milestone Nov 23, 2023
@rapsealk rapsealk self-assigned this Nov 23, 2023
@rapsealk rapsealk added the effort:easy Need to understand only a specific region of codes (good first issue, easy). label Nov 23, 2023
@github-actions github-actions bot added comp:webserver Related to Web Server component size:S 10~30 LoC labels Nov 23, 2023
@rapsealk rapsealk added type:enhance Enhance component, behavior, internals without user-facing features and removed comp:webserver Related to Web Server component size:S 10~30 LoC labels Nov 23, 2023
@rapsealk rapsealk added comp:webserver Related to Web Server component size:S 10~30 LoC labels Nov 23, 2023
agatha197
agatha197 approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rapsealk rapsealk changed the title feat: Add ui.menu_inactivelist to webserver.conf feat: Use ui.menu_blocklist to hide and ui.menu_inactivelist to disable menu items Nov 23, 2023
@kyujin-cho kyujin-cho added this pull request to the merge queue Nov 28, 2023
@kyujin-cho kyujin-cho removed this pull request from the merge queue due to a manual request Nov 28, 2023
@kyujin-cho kyujin-cho enabled auto-merge December 13, 2023 15:08
@kyujin-cho kyujin-cho added this pull request to the merge queue Dec 13, 2023
Merged via the queue into main with commit 53f001a Dec 13, 2023
25 checks passed
@kyujin-cho kyujin-cho deleted the feature/separate-webui-blocked-inactive-menu-item branch December 13, 2023 15:13
kyujin-cho added a commit that referenced this pull request Dec 13, 2023
@rapsealk @kyujin-cho
feat: Use ui.menu_blocklist to hide and ui.menu_inactivelist to d…
56f2397 
…isable menu items (#1733)

Co-authored-by: Kyujin Cho <[email protected]>
Backported-from: main
Backported-to: 23.09
@yomybaby yomybaby mentioned this pull request Jan 8, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agatha197 agatha197 agatha197 approved these changes

@kyujin-cho kyujin-cho kyujin-cho approved these changes

Assignees

@rapsealk rapsealk

Labels
area:ux UI / UX issue. comp:webserver Related to Web Server component comp:webui Related to WebUI component effort:easy Need to understand only a specific region of codes (good first issue, easy). size:S 10~30 LoC type:enhance Enhance component, behavior, internals without user-facing features urgency:2 With time limit, it should be finished within it; otherwise, resolve it when no other chores.
Projects
None yet
Milestone
23.09
Development

Successfully merging this pull request may close these issues.
3 participants
@rapsealk @kyujin-cho @agatha197