Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: single agent per kernel resource usage #1725

Merged
merged 5 commits into from
Mar 31, 2024
Merged

fix: single agent per kernel resource usage #1725

merged 5 commits into from
Mar 31, 2024

Conversation

fregataa
Copy link
Member

@fregataa fregataa commented Nov 21, 2023 •
edited
Loading

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • API server-client counterparts (e.g., manager API -> client SDK)

@fregataa fregataa added this to the 24.03 milestone Nov 21, 2023
@fregataa fregataa requested a review from agatha197 November 21, 2023 02:25
@fregataa fregataa self-assigned this Nov 21, 2023
@github-actions github-actions bot added comp:manager Related to Manager component size:XS ~10 LoC labels Nov 21, 2023
agatha197
agatha197 approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kyujin-cho
kyujin-cho requested changes Nov 22, 2023
View reviewed changes
Copy link
Member

@kyujin-cho kyujin-cho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been told from Frontend team that there will be no backward compatibility issue due to JSON key renaming. Please just take care about the news fragment error only.

@fregataa fregataa requested a review from kyujin-cho November 22, 2023 05:26
@fregataa
Merge remote-tracking branch 'origin/fix/single-agent-per-kernel-reso…
288eee4 
…urce-usage' into fix/single-agent-per-kernel-resource-usage
@kyujin-cho kyujin-cho added this pull request to the merge queue Mar 31, 2024
Merged via the queue into main with commit 5a63a55 Mar 31, 2024
22 checks passed
@kyujin-cho kyujin-cho deleted the fix/single-agent-per-kernel-resource-usage branch March 31, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agatha197 agatha197 agatha197 approved these changes

@kyujin-cho kyujin-cho kyujin-cho approved these changes

Assignees

@fregataa fregataa

Labels
comp:manager Related to Manager component size:XS ~10 LoC
Projects
None yet
Milestone
24.03
Development

Successfully merging this pull request may close these issues.
3 participants
@fregataa @kyujin-cho @agatha197