Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Missing wsproxy.url config and make it WSL-compatible #1722

Merged
merged 11 commits into from
Nov 21, 2023
Merged

fix: Missing wsproxy.url config and make it WSL-compatible #1722

merged 11 commits into from
Nov 21, 2023

Conversation

achimnol
Copy link
Member

@achimnol achimnol commented Nov 16, 2023 •
edited
Loading

follow-up to #1694.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Documentation

@achimnol achimnol added this to the 24.03 milestone Nov 16, 2023
@achimnol achimnol added type:bug Reports about that are not working comp:installer Related to Installer type:enhance Enhance component, behavior, internals without user-facing features labels Nov 16, 2023
@achimnol achimnol self-assigned this Nov 16, 2023
@github-actions github-actions bot added the size:XS ~10 LoC label Nov 16, 2023
@achimnol
fix: Change the default port of wsproxy
4959759 
- Windows 10 or later seems to have some service in `svchost.exe`
  occupying the 5050 port.
@achimnol
doc: Add news fragment
1ab3e09
@achimnol achimnol changed the title fix: Missing wsproxy.url and make it WSL-compatible fix: Missing wsproxy.url config and make it WSL-compatible Nov 16, 2023
@github-actions github-actions bot added size:M 30~100 LoC and removed size:XS ~10 LoC labels Nov 21, 2023
@github-actions github-actions bot added size:L 100~500 LoC and removed size:M 30~100 LoC labels Nov 21, 2023
@achimnol achimnol marked this pull request as ready for review November 21, 2023 23:34
@achimnol achimnol added this pull request to the merge queue Nov 21, 2023
Merged via the queue into main with commit e38733b Nov 21, 2023
20 checks passed
@achimnol achimnol deleted the fix/installer-missing-wsproxy-url-config branch November 21, 2023 23:39
@achimnol achimnol modified the milestones: 24.03, 23.09 Nov 22, 2023
achimnol added a commit that referenced this pull request Nov 22, 2023
@achimnol
fix: Missing wsproxy.url config and make it WSL-compatible (#1722)
c98e746 
Backported-from: main
Backported-to: 23.09
achimnol added a commit that referenced this pull request Nov 22, 2023
@achimnol
fix: Missing wsproxy.url config and make it WSL-compatible (#1722)
b25d4d5 
Backported-from: main
Backported-to: 23.09
This was referenced Nov 22, 2023
Merged
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@achimnol achimnol

Labels
comp:installer Related to Installer size:L 100~500 LoC type:bug Reports about that are not working type:enhance Enhance component, behavior, internals without user-facing features
Projects
None yet
Milestone
23.09
Development

Successfully merging this pull request may close these issues.
1 participant
@achimnol