Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Community Installer running on macOS #1716

Merged
merged 8 commits into from
Nov 14, 2023

Conversation

achimnol
Copy link
Member

@achimnol achimnol commented Nov 14, 2023

A follow-up fix to #1694 in macOS environments.

@achimnol achimnol added this to the 24.03 milestone Nov 14, 2023
@achimnol achimnol added type:bug Reports about that are not working comp:installer Related to Installer labels Nov 14, 2023
@achimnol achimnol self-assigned this Nov 14, 2023
@github-actions github-actions bot added the size:XS ~10 LoC label Nov 14, 2023
@github-actions github-actions bot added size:S 10~30 LoC and removed size:XS ~10 LoC labels Nov 14, 2023
@achimnol achimnol force-pushed the fix/follow-up-fixes-of-installer branch from 96aa935 to 41b2a18 Compare November 14, 2023 06:01
@github-actions github-actions bot added size:M 30~100 LoC and removed size:S 10~30 LoC labels Nov 14, 2023
@achimnol achimnol added the skip:changelog Make the action workflow to skip towncrier check label Nov 14, 2023
@achimnol achimnol changed the title fix: Strip the subprocess outputs when detecting platform fix: Community Installer running on macOS Nov 14, 2023
@github-actions github-actions bot added size:L 100~500 LoC and removed size:M 30~100 LoC labels Nov 14, 2023
@achimnol achimnol marked this pull request as ready for review November 14, 2023 08:08
@achimnol achimnol added this pull request to the merge queue Nov 14, 2023
Merged via the queue into main with commit 86ea9ec Nov 14, 2023
20 checks passed
@achimnol achimnol deleted the fix/follow-up-fixes-of-installer branch November 14, 2023 08:12
@achimnol achimnol modified the milestones: 24.03, 23.09 Nov 22, 2023
achimnol added a commit that referenced this pull request Nov 22, 2023
Backported-from: main
Backported-to: 23.09
achimnol added a commit that referenced this pull request Nov 22, 2023
Backported-from: main
Backported-to: 23.09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:installer Related to Installer size:L 100~500 LoC skip:changelog Make the action workflow to skip towncrier check type:bug Reports about that are not working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant