-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Community Installer running on macOS #1716
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achimnol
added
type:bug
Reports about that are not working
comp:installer
Related to Installer
labels
Nov 14, 2023
achimnol
force-pushed
the
fix/follow-up-fixes-of-installer
branch
from
November 14, 2023 06:01
96aa935
to
41b2a18
Compare
achimnol
added
the
skip:changelog
Make the action workflow to skip towncrier check
label
Nov 14, 2023
achimnol
changed the title
fix: Strip the subprocess outputs when detecting platform
fix: Community Installer running on macOS
Nov 14, 2023
achimnol
added a commit
that referenced
this pull request
Nov 22, 2023
Backported-from: main Backported-to: 23.09
achimnol
added a commit
that referenced
this pull request
Nov 22, 2023
Backported-from: main Backported-to: 23.09
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp:installer
Related to Installer
size:L
100~500 LoC
skip:changelog
Make the action workflow to skip towncrier check
type:bug
Reports about that are not working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up fix to #1694 in macOS environments.