Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing resource-usage fields #1707

Merged
merged 5 commits into from
Nov 14, 2023
Merged

fix: add missing resource-usage fields #1707

merged 5 commits into from
Nov 14, 2023

Conversation

fregataa
Copy link
Member

@fregataa fregataa commented Nov 8, 2023 •
edited
Loading

resolves #1706

counter part of webui: #1715

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • API server-client counterparts (e.g., manager API -> client SDK)

@fregataa fregataa added this to the 24.03 milestone Nov 8, 2023
@fregataa fregataa requested a review from agatha197 November 8, 2023 13:47
@fregataa fregataa self-assigned this Nov 8, 2023
@github-actions github-actions bot added comp:manager Related to Manager component type:feature Add new features urgency:2 With time limit, it should be finished within it; otherwise, resolve it when no other chores. size:M 30~100 LoC labels Nov 8, 2023
@github-actions github-actions bot added size:L 100~500 LoC and removed size:M 30~100 LoC labels Nov 9, 2023
@achimnol
Copy link
Member

@fregataa Does this introduce any breaking changes to other components (frontends, control panel, etc.)?

@agatha197
Copy link
Contributor

@fregataa Does this introduce any breaking changes to other components (frontends, control panel, etc.)?

https://github.com/lablup/backend.ai-control-panel/pull/473 will handle.

@achimnol achimnol added this pull request to the merge queue Nov 14, 2023
Merged via the queue into main with commit b5a519b Nov 14, 2023
20 checks passed
@achimnol achimnol deleted the fix/add-missing-resource-usage-fields branch November 14, 2023 05:03
@fregataa fregataa mentioned this pull request Nov 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agatha197 agatha197 Awaiting requested review from agatha197

Assignees

@fregataa fregataa

Labels
comp:manager Related to Manager component size:L 100~500 LoC type:feature Add new features urgency:2 With time limit, it should be finished within it; otherwise, resolve it when no other chores.
Projects
None yet
Milestone
24.03
Development

Successfully merging this pull request may close these issues.

Let's fillup the missing fields of usage_per_period
3 participants
@fregataa @achimnol @agatha197