-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Add users_to_add
and users_to_remove
fields to replace user update mode
#1705
base: main
Are you sure you want to change the base?
Conversation
added_users
and removed_users
fields to replace user update mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is an active API operation, we should use the active voice for the field names.
Let's rename:
added_users
→add_users
removed_users
→remove_users
added_users
and removed_users
fields to replace user update modeadd_users
and remove_users
fields to replace user update mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other parts looks good. Just a minor update please.
add_users
and remove_users
fields to replace user update modeusers_to_add
and users_to_remove
fields to replace user update mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
partial-fix #1697
ModifyGroup
mutation has been used to add users to group and delete users from group.Let's refactor the mutation.
Revert some description/deprecation_reason string generator functions for good readability
Test query
Checklist: (if applicable)