Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Explicit Undefined value for GraphQL mutation inputs #1674

Merged
merged 3 commits into from
Oct 31, 2023
Merged

refactor: Explicit Undefined value for GraphQL mutation inputs #1674

merged 3 commits into from
Oct 31, 2023

Conversation

achimnol
Copy link
Member

@achimnol achimnol commented Oct 31, 2023 •
edited
Loading

resolves #1647.

  • refactor: Use the explicit Undefined value for unspecified mutation input fields
  • doc: Add news fragment

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Documentation
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to demonstrate the difference of before/after

@achimnol achimnol added comp:manager Related to Manager component type:refactor Refactor codes or add tests. impact:invisible This change is invisible to users (internal changes). urgency:4 As soon as feasible, implementation is essential. labels Oct 31, 2023
@achimnol achimnol self-assigned this Oct 31, 2023
@achimnol achimnol added this to the 24.03 milestone Oct 31, 2023
@github-actions github-actions bot added the size:S 10~30 LoC label Oct 31, 2023
@achimnol achimnol modified the milestones: 24.03, 23.09 Oct 31, 2023
@github-actions github-actions bot added area:upstream Issues with root cause from upstream 3rd parties type:enhance Enhance component, behavior, internals without user-facing features labels Oct 31, 2023
yomybaby
yomybaby approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@achimnol achimnol added this pull request to the merge queue Oct 31, 2023
Merged via the queue into main with commit 7d46828 Oct 31, 2023
18 checks passed
@achimnol achimnol deleted the refactor/explicit-undefined-value-for-graphql-mutation-inputs branch October 31, 2023 08:59
achimnol added a commit that referenced this pull request Oct 31, 2023
@achimnol
refactor: Explicit Undefined value for GraphQL mutation inputs (#1674)
15ae195 
Backported-from: main
Backported-to: 23.09
@rapsealk rapsealk mentioned this pull request Nov 2, 2023
Merged
5 tasks
@yomybaby yomybaby mentioned this pull request Nov 3, 2023
Closed
5 tasks
@achimnol achimnol mentioned this pull request Nov 4, 2023
Merged
5 tasks
@kyujin-cho kyujin-cho mentioned this pull request Dec 15, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yomybaby yomybaby yomybaby approved these changes

@kyujin-cho kyujin-cho Awaiting requested review from kyujin-cho

Assignees

@achimnol achimnol

Labels
area:upstream Issues with root cause from upstream 3rd parties comp:manager Related to Manager component impact:invisible This change is invisible to users (internal changes). size:S 10~30 LoC type:enhance Enhance component, behavior, internals without user-facing features type:refactor Refactor codes or add tests. urgency:4 As soon as feasible, implementation is essential.
Projects
None yet
Milestone
23.09
Development

Successfully merging this pull request may close these issues.

Utilize UNDEFINED introduced in Graphene v3.3
2 participants
@achimnol @yomybaby