Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: add allow_app_download_panel option to webserver config #1664

Merged
merged 2 commits into from
Oct 30, 2023
Merged

add: add allow_app_download_panel option to webserver config #1664

merged 2 commits into from
Oct 30, 2023

Conversation

agatha197
Copy link
Contributor

related PR: lablup/backend.ai-webui#1996
Add allow_app_download_panel option to webserver config file to display or hide the webui app download panel.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Documentation
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to demonstrate the difference of before/after

@agatha197 agatha197 added type:feature Add new features comp:webserver Related to Web Server component effort:easy Need to understand only a specific region of codes (good first issue, easy). impact:invisible This change is invisible to users (internal changes). urgency:3 Must be finished within a certain time frame. labels Oct 27, 2023
@agatha197 agatha197 added this to the 23.09 milestone Oct 27, 2023
@agatha197 agatha197 self-assigned this Oct 27, 2023
@github-actions github-actions bot added the size:XS ~10 LoC label Oct 27, 2023
@agatha197 agatha197 requested a review from kyujin-cho October 27, 2023 08:07
@kyujin-cho kyujin-cho added this pull request to the merge queue Oct 30, 2023
Merged via the queue into main with commit 24fb925 Oct 30, 2023
18 checks passed
@kyujin-cho kyujin-cho deleted the feature/add-allow-app-download-url-to-webserver branch October 30, 2023 05:47
kyujin-cho pushed a commit that referenced this pull request Nov 1, 2023
@agatha197 @kyujin-cho
add: add allow_app_download_panel option to webserver config (#1664)
85a6335 
Backported-from: main
Backported-to: 23.09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyujin-cho kyujin-cho kyujin-cho approved these changes

Assignees

@agatha197 agatha197

Labels
comp:webserver Related to Web Server component effort:easy Need to understand only a specific region of codes (good first issue, easy). impact:invisible This change is invisible to users (internal changes). size:XS ~10 LoC type:feature Add new features urgency:3 Must be finished within a certain time frame.
Projects
None yet
Milestone
23.09
Development

Successfully merging this pull request may close these issues.
2 participants
@agatha197 @kyujin-cho