fix: Replace manager's shared redis config with the common redis config #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achimnol
added
type:bug
.fix.md -> 1653.fix.md
achimnol
added
the
platform:general
jopemachine
approved these changes
Oct 25, 2023
achimnol
deleted the
fix/replace-manager-redis-config-with-common-redis-config
branch
achimnol
added a commit
that referenced
this pull request
Oct 25, 2023
…ig (#1653) Backported-from: main Backported-to: 23.09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up fix to #1586.
All redis users should consult
common.config.redis_config_ivconsistently,and it should have the new sentinel config for consistency.
Previously, manager only recognized the new sentinel config while others relying on
common.config.redis_config_ivwere silently ignoring the sentinel config.Of course,
redis-pycurrently has many issues related with connection pools and sentinel supports, but those are different stories....Checklist: (if applicable)