Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inference session not created when service name is too long #1642

Merged
merged 5 commits into from
Nov 1, 2023

Conversation

kyujin-cho
Copy link
Member

This PR fixes inference session fails to be created when service name is longer than 28 characters. This PR also includes a patch which adds error field to GraphQL's routing object.

Checklist: (if applicable)

@kyujin-cho kyujin-cho marked this pull request as draft October 20, 2023 04:57
@github-actions github-actions bot added comp:manager Related to Manager component size:M 30~100 LoC labels Oct 20, 2023
@kyujin-cho kyujin-cho added this to the 23.09 milestone Oct 30, 2023
@kyujin-cho kyujin-cho marked this pull request as ready for review October 30, 2023 06:22
@kyujin-cho kyujin-cho requested a review from achimnol October 31, 2023 09:54
@kyujin-cho kyujin-cho added this pull request to the merge queue Nov 1, 2023
Merged via the queue into main with commit c46b49b Nov 1, 2023
18 checks passed
@kyujin-cho kyujin-cho deleted the fix/per-routing-error branch November 1, 2023 04:11
kyujin-cho added a commit that referenced this pull request Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:manager Related to Manager component size:M 30~100 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant